search

Aivean / royalroad-downloader

https://royalroad.com book downloader
MIT License
57 stars 4 forks source link

[Feature Request] Option to disable converting to data URIs #31

Closed TadaCZE closed 8 months ago

TadaCZE commented 8 months ago

The behavior of downloading images and embedding them into the document is useful in some situations, but not all of them. It would in some situations be more useful to leave the links as is or download the images into a folder and link to them.

TadaCZE commented 8 months ago

An option not to include images at all would also be a good idea.

Aivean commented 8 months ago

Out of curiosity, could you please list some of those situations? When implementing this feature I considered making it optional (which is not hard to do), but couldn't think of any specific compelling argument to do so.

I mean, technically, it swells the size of the html and takes a bit longer to download the book, but these effects seem to be negligent, unless I'm missing something.

Anyway, I'll get to implementing the option at some point, meanwhile you can use the previous version as a workaround.