search

Aiven-Open / auth-for-apache-kafka

Aiven Authentication and Authorization Plugins for Apache Kafka®
Apache License 2.0
2 stars 3 forks source link

Fix compatibility with Kafka >= 3.8 #194

Closed juha-aiven closed 3 months ago

juha-aiven commented 3 months ago

Stop using io.aiven.kafka.auth.audit.Session from Kafka that is no longer present in Kafka >= 3.8.

Add io.aiven.kafka.auth.audit.Session to replace that. In the new class, add properly named getter methods and make the fields private.

Fixes #193.

jlprat commented 3 months ago

Regarding the getter setter. It all boils down to when did you get POJOs best practices imprinted in your mind. This is a class that could definitely be replaced with a Java record as it was a case class in Scala. But, in the end, this looks like something that can be decided project wise and chose a "policy" for POJOs and style guide for some type of stylistic questions.