Refactor of HttpSender implementations with Factory Pattern (1/2)

aprodhomme-dkt commented 1 year ago

This PR aims to have clearer responsibilities between the multiple HttpSender implementations. This is required to increase code coverage before introducing a new way to retrieve an access token (see 2nd PR: https://github.com/aiven/http-connector-for-apache-kafka/pull/172)

Changes:

refactor Http senders to expose a factory HttpSenderFactory and provide an implementation according to the configuration
Use abstraction AbstractHttpSender for sending message and sending with retry
Every Http request is handled by a HttpSender implementation, even retrieving an access token with AccessTokenHttpSender
Each HttpSender implementation creates its own HttpRequestBuilder with separate responsibilities

This refactor allows to test the HttpRequest that is sent to the API publisher and it covers all scenarios depending on the configuration.

aprodhomme-dkt commented 11 months ago

Here you go :)

aprodhomme-dkt commented 11 months ago

@jeqo any news on those PRs?

aprodhomme-dkt commented 10 months ago

Hi @jeqo and @jjaakola-aiven, thanks for your reviews. I have just took into account your last comments.

jeqo commented 10 months ago

Thanks, @aprodhomme-dkt! Let's have a look at #172 to wrap up this contribution 🙌🏽

Aiven-Open / http-connector-for-apache-kafka

Refactor of HttpSender implementations with Factory Pattern (1/2) #171