search

Aiven-Open / klaw

Klaw, the latest OS tool by Aiven, helps enterprises cope with Apache Kafka(r) topics, schema registry and connectors governance by introducing roles/authorizations to users of various teams of an org.
https://www.klaw-project.io/
Apache License 2.0
150 stars 60 forks source link

refactor(coral): Replace `Dialog` with `type={"confirmation"}` with `Toast` component from `aquarium` #614

Closed programmiri closed 1 year ago

programmiri commented 1 year ago

What is this about?

We implemented a "confirmation modal" pattern to give feedback on successfully accomplishing a task because aquarium did not have

https://github.com/aiven/klaw/assets/20607294/5f8d6851-4a9b-4384-9d10-2f5e1b5272f2

These are all Dialog component with type={"confirmation"} .

With the latest update to aquarium (https://github.com/aiven/klaw/pull/1270), Toast is available, and should be used in all instances where we currently use Dialog component with type={"confirmation"} .

https://github.com/aiven/klaw/assets/20607294/369c9bd7-735c-4a80-854b-53b1a3159efd

programmiri commented 1 year ago

Update from this week:

The DS decided they will add a Notification component to the DS for us to use, so we get the same look as console. They won't for now add the functionality of showing the notification etc. In console, that's entangled with the redux store, and it's not valuable for them to update that right now to a potential DS component.

So we can now plan were and how we want to use notifications and look into implementation (maybe there as good lib that makes it easy and accessible already?)