Aiven-Open / klaw

Klaw, the latest OS tool by Aiven, helps enterprises cope with Apache Kafka(r) topics, schema registry and connectors governance by introducing roles/authorizations to users of various teams of an org.
https://www.klaw-project.io/
Apache License 2.0
141 stars 58 forks source link

refactor(coral): Replace custom Pagination with Aquarium Pagination #714

Open mathieu-anderson opened 1 year ago

mathieu-anderson commented 1 year ago

What is currently missing?

We have a custom Pagination component (src/app/components/Pagination). The reasons for it to exist are twofold:

Using custom components when one already exists in Aquarium is not desirable at this point.

How could this be improved?

The breaking issue has been resolved, and will be released in an upcoming Aquarium version. We should consider using the component as soon as the bug is fixed in the released version, and opening an issue with the Aquarium project to fix the a11y ambiguity.

Todo:

Is this a feature you would work on yourself?

programmiri commented 1 year ago

Note about a11y

This should be fixed before using the component (either temp fix on our end or in DS) and we can use the temp implementation we already have until it works. Otherwise we willingly break functionality for certain users for an unclear amount of time without any need and value other than removing a bit of code. (removing code is super nice, but not if users pay the price ^^)