search

Aiven-Open / myhoard

MySQL Backup and Point-in-time Recovery service
Apache License 2.0
93 stars 20 forks source link

remove tests for percona-xtrabackup-8.0.28-20-01 #148

Closed kathia-barahona closed 1 year ago

kathia-barahona commented 1 year ago

checks for this version are currently failing, I guess skipping tests for mysql 8.0.26 is alright

kathia-barahona commented 1 year ago

nit: I'd probably change that line to reference a newer version as well, if we're removing the testing for it: https://github.com/aiven/myhoard/blob/master/README.md?plain=1#L791

uu good catch :+1:

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.96 :warning:

Comparison is base (6ebbd99) 78.87% compared to head (d525b4c) 77.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #148 +/- ## ========================================== - Coverage 78.87% 77.91% -0.96% ========================================== Files 17 17 Lines 4293 4293 Branches 975 975 ========================================== - Hits 3386 3345 -41 - Misses 679 715 +36 - Partials 228 233 +5 ``` | [Impacted Files](https://codecov.io/gh/aiven/myhoard/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven) | Coverage Δ | | |---|---|---| | [myhoard/restore\_coordinator.py](https://codecov.io/gh/aiven/myhoard/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven#diff-bXlob2FyZC9yZXN0b3JlX2Nvb3JkaW5hdG9yLnB5) | `78.35% <0.00%> (-3.27%)` | :arrow_down: | | [myhoard/basebackup\_restore\_operation.py](https://codecov.io/gh/aiven/myhoard/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven#diff-bXlob2FyZC9iYXNlYmFja3VwX3Jlc3RvcmVfb3BlcmF0aW9uLnB5) | `82.27% <0.00%> (-2.28%)` | :arrow_down: | | [myhoard/basebackup\_operation.py](https://codecov.io/gh/aiven/myhoard/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven#diff-bXlob2FyZC9iYXNlYmFja3VwX29wZXJhdGlvbi5weQ==) | `90.26% <0.00%> (-1.13%)` | :arrow_down: | | [myhoard/backup\_stream.py](https://codecov.io/gh/aiven/myhoard/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven#diff-bXlob2FyZC9iYWNrdXBfc3RyZWFtLnB5) | `77.55% <0.00%> (-0.29%)` | :arrow_down: | | [myhoard/controller.py](https://codecov.io/gh/aiven/myhoard/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven#diff-bXlob2FyZC9jb250cm9sbGVyLnB5) | `79.61% <0.00%> (-0.20%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.