Aiven-Open / myhoard

MySQL Backup and Point-in-time Recovery service
Apache License 2.0
93 stars 20 forks source link

Make use of ssl_require config in restore coordinator [BF-1965] #158

Closed ettanany closed 1 year ago

ettanany commented 1 year ago

Ensure require_ssl config is passed down (from Controller) to RestoreCoordinator.

BF-1965

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.04 :tada:

Comparison is base (36b22bc) 77.89% compared to head (cbec59d) 77.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #158 +/- ## ========================================== + Coverage 77.89% 77.93% +0.04% ========================================== Files 17 17 Lines 4351 4351 Branches 984 984 ========================================== + Hits 3389 3391 +2 + Misses 728 727 -1 + Partials 234 233 -1 ``` | [Impacted Files](https://codecov.io/gh/aiven/myhoard/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven) | Coverage Δ | | |---|---|---| | [myhoard/restore\_coordinator.py](https://codecov.io/gh/aiven/myhoard/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven#diff-bXlob2FyZC9yZXN0b3JlX2Nvb3JkaW5hdG9yLnB5) | `78.28% <ø> (ø)` | | ... and [2 files with indirect coverage changes](https://codecov.io/gh/aiven/myhoard/pull/158/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.