Aiven-Open / myhoard

MySQL Backup and Point-in-time Recovery service
Apache License 2.0
93 stars 20 forks source link

Backup is not broken on disk full [BF-2051] #160

Closed Mulugruntz closed 1 year ago

Mulugruntz commented 1 year ago

Mainly three things in this PR:

BF-2051

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 96.29% and project coverage change: -0.75 :warning:

Comparison is base (de5af5b) 78.83% compared to head (2911b12) 78.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #160 +/- ## ========================================== - Coverage 78.83% 78.09% -0.75% ========================================== Files 17 17 Lines 4351 4368 +17 Branches 984 971 -13 ========================================== - Hits 3430 3411 -19 - Misses 688 726 +38 + Partials 233 231 -2 ``` | [Impacted Files](https://app.codecov.io/gh/aiven/myhoard/pull/160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven) | Coverage Δ | | |---|---|---| | [myhoard/controller.py](https://app.codecov.io/gh/aiven/myhoard/pull/160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven#diff-bXlob2FyZC9jb250cm9sbGVyLnB5) | `79.98% <66.66%> (-0.29%)` | :arrow_down: | | [myhoard/backup\_stream.py](https://app.codecov.io/gh/aiven/myhoard/pull/160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven#diff-bXlob2FyZC9iYWNrdXBfc3RyZWFtLnB5) | `77.34% <100.00%> (-0.28%)` | :arrow_down: | | [myhoard/basebackup\_restore\_operation.py](https://app.codecov.io/gh/aiven/myhoard/pull/160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven#diff-bXlob2FyZC9iYXNlYmFja3VwX3Jlc3RvcmVfb3BlcmF0aW9uLnB5) | `87.77% <100.00%> (+6.86%)` | :arrow_up: | | [myhoard/errors.py](https://app.codecov.io/gh/aiven/myhoard/pull/160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven#diff-bXlob2FyZC9lcnJvcnMucHk=) | `63.63% <100.00%> (+3.63%)` | :arrow_up: | | [myhoard/restore\_coordinator.py](https://app.codecov.io/gh/aiven/myhoard/pull/160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven#diff-bXlob2FyZC9yZXN0b3JlX2Nvb3JkaW5hdG9yLnB5) | `77.63% <100.00%> (-4.11%)` | :arrow_down: | | [myhoard/util.py](https://app.codecov.io/gh/aiven/myhoard/pull/160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven#diff-bXlob2FyZC91dGlsLnB5) | `89.00% <100.00%> (+0.05%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/aiven/myhoard/pull/160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.