search

Aiven-Open / myhoard

MySQL Backup and Point-in-time Recovery service
Apache License 2.0
93 stars 20 forks source link

Read xtrabackup settings from config #177

Closed kathia-barahona closed 1 year ago

kathia-barahona commented 1 year ago

About this change: What it does, why it matters

https://github.com/Aiven-Open/myhoard/commit/194c6c9051f452cc8e600f742490cbe0901551ec Supports xtrabackup multithreading parameters, but seems I missed passing the parameters from the config file to the BackupStream. These changes fix this.

codecov-commenter commented 1 year ago

Codecov Report

Merging #177 (8686395) into master (9fb9bcc) will increase coverage by 0.05%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   79.01%   79.07%   +0.05%     
==========================================
  Files          17       17              
  Lines        4493     4496       +3     
  Branches     1016     1016              
==========================================
+ Hits         3550     3555       +5     
+ Misses        711      706       -5     
- Partials      232      235       +3
Files Coverage Δ
myhoard/backup_stream.py 79.16% <100.00%> (+0.02%) :arrow_up:
myhoard/controller.py 82.44% <100.00%> (+0.01%) :arrow_up:
myhoard/util.py 89.03% <100.00%> (+0.02%) :arrow_up:
myhoard/myhoard.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more