search

Aiven-Open / opensearch-connector-for-apache-kafka

Aiven's OpenSearch® Connector for Apache Kafka®
Apache License 2.0
64 stars 35 forks source link

Adding AWS SigV4 authentication #240

Open fabiojmendes opened 11 months ago

fabiojmendes commented 11 months ago

This pull request implements the AWS SigV4 as described in #197

reta commented 11 months ago

@fabiojmendes I believe we do not intent to bundle vendor specific schemes into the connector but offer the capability to have it packaged / bundled with additional JARs that could be loaded using ServiceLoader mechanism, @willyborankin please correct me if I am wrong here.

fabiojmendes commented 10 months ago

I see your point, but perhaps supporting aws out of the box would be worth the trade off.

I believe that using opensearch as an aws service is a very common use case.

willyborankin commented 10 months ago

@fabiojmendes I believe we do not intent to bundle vendor specific schemes into the connector but offer the capability to have it packaged / bundled with additional JARs that could be loaded using ServiceLoader mechanism, @willyborankin please correct me if I am wrong here.

@reta TBH I do not see any problems with adding it to the connector. It is a "kinda" connector way. In any case configuration for custom certificates needs to be added as well.

willyborankin commented 10 months ago

@fabiojmendes I believe we do not intent to bundle vendor specific schemes into the connector but offer the capability to have it packaged / bundled with additional JARs that could be loaded using ServiceLoader mechanism, @willyborankin please correct me if I am wrong here.

@reta TBH I do not see any problems with adding it to the connector. It is a "kinda" connector way. In any case configuration for custom certificates needs to be added as well.

@fabiojmendes. We do want to see you solution.I personally think this is a valuable feature. Since we need to add support SSL configuration it will take sometime. @reta I think we need to add a separate project which will build together with the connector as separate jar/jars with additional auth libs. Wdyt?

fabiojmendes commented 10 months ago

Sounds good @willyborankin, do you need any changes from my side at this point?