search

Aiven-Open / pghoard

PostgreSQL® backup and restore service
http://aiven-open.github.io/pghoard/
Apache License 2.0
1.32k stars 97 forks source link

Ensure progress metric is updated frequently during basebackup #540

Closed nicois closed 2 years ago

nicois commented 2 years ago

The pghoard.basebackup_estimated_progress was added earlier this year, but often does not fire until the basebackup is already 100% complete.

This commit increases the frequency at which the metric is emitted.

codecov[bot] commented 2 years ago

Codecov Report

Merging #540 (220b0f3) into main (17d9ac8) will decrease coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   89.47%   89.40%   -0.07%     
==========================================
  Files          29       29              
  Lines        4492     4492              
==========================================
- Hits         4019     4016       -3     
- Misses        473      476       +3
Impacted Files Coverage Δ
pghoard/basebackup.py 85.13% <100.00%> (+0.17%) :arrow_up:
pghoard/fetcher.py 95.74% <0.00%> (-2.13%) :arrow_down:
pghoard/common.py 93.04% <0.00%> (-1.31%) :arrow_down:
pghoard/pghoard.py 82.79% <0.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17d9ac8...220b0f3. Read the comment docs.

alexole commented 2 years ago

Sorry did not see this PR before creating another PR where this is addressed https://github.com/aiven/pghoard/pull/550 There were some more changes needed anyway and there are conflicts, so I will close this PR.