Aiven-Open / pghoard

PostgreSQL® backup and restore service

http://aiven-open.github.io/pghoard/

Apache License 2.0

1.3k stars 99 forks source link

handle a graceful shutdown on request #594

Open kathia-barahona opened 1 year ago

kathia-barahona commented 1 year ago

About this change - What it does

Handles graceful shutdowns by making sure all compressed files get uploaded ~(considers also partial files)~ Edit: renaming partial files is dangerous, after testing I didn't got the expected results (duplicated segments on different timelines)

Why this way

Shutting down pghoard can be dangerous, leading to missed segments if not all information was uploaded. To avoid this, its better to make sure all tasks/events were completed.

kathia-barahona commented 1 year ago

:/ Build failing, seems rohmu got updated again (using Protocol, not supported on 3.7)

Mulugruntz commented 1 year ago

:/ Build failing, seems rohmu got updated again (using Protocol, not supported on 3.7)

To be noted that Python 3.7 reached EOL a week ago. That raises the question on whether we want to support a Python version on pghoard that is no longer officially supported and will no longer receive security patches. I'd be in favour of removing 3.7 from the CI here.