search

Aiven-Open / pghoard

PostgreSQL® backup and restore service
http://aiven-open.github.io/pghoard/
Apache License 2.0
1.32k stars 97 forks source link

Remove support for old python versions #595

Open packi opened 1 year ago

packi commented 1 year ago

Debian just dropped 3.10 in their latest release.

codecov[bot] commented 1 year ago

Codecov Report

Merging #595 (57a9350) into main (6dce5bf) will decrease coverage by 0.11%. The diff coverage is n/a.

:exclamation: Current head 57a9350 differs from pull request most recent head bf5e852. Consider uploading reports for the commit bf5e852 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/aiven/pghoard/pull/595/graphs/tree.svg?width=650&height=150&src=pr&token=nLr7M7hvCx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven)](https://app.codecov.io/gh/aiven/pghoard/pull/595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven) ```diff @@ Coverage Diff @@ ## main #595 +/- ## ========================================== - Coverage 91.31% 91.20% -0.11% ========================================== Files 32 32 Lines 4684 4684 ========================================== - Hits 4277 4272 -5 - Misses 407 412 +5 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/aiven/pghoard/pull/595/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiven)
rdunklau commented 1 year ago

Is it really necessary to drop old versions ? A lot of users may be using older distros, as long as it doesn't cost us too much it would be nice to keep pghoard working for them.

giacomo-alzetta-aiven commented 1 year ago

Dropping python3.7 is fine since it is EOLed (recent rohmu versions have dropped support as well), but I wouldn't just drop 3.8-3.10 without any particular reason.