search

Aiven-Open / prometheus-exporter-plugin-for-opensearch

Prometheus exporter plugin for OpenSearch & OpenSearch Mixin
Apache License 2.0
120 stars 37 forks source link

Update README.md to clarify plugin/opensearch version sync OLD #198

Closed jeroenhabets closed 1 year ago

jeroenhabets commented 1 year ago

See NOTE: under Compatibility Matrix

As requested by @lukas-vlcek in #197

lukas-vlcek commented 1 year ago

@jeroenhabets Looking good. Maybe we can make it even more precise and point to plugins documentation here that also further explains the relation wrt to "sub"-patch plugin version, ie. all plugins 2.9.0.x will work only with OpenSearch 2.9.0.

Oh, and please provide DCO (--signoff), see https://github.com/aiven/prometheus-exporter-plugin-for-opensearch/issues/78

Each commit must include a DCO which looks like this

Signed-off-by: Jane Smith jane.smith@email.com

You may type this line on your own when writing your commit messages. However, if your user.name and user.email are set in your git configs, you can use -s or --signoff to add the Signed-off-by line to the end of the commit message.

jeroenhabets commented 1 year ago

@lukas-vlcek I just commited an update including a Signed-off-by line.

lukas-vlcek commented 1 year ago

@jeroenhabets The first commit is still missing the DCO. Maybe you can merge both commits into a single commit and have only this one commit signed?

jeroenhabets commented 1 year ago

Sorry @lukas-vlcek, then it's easier just to redo from start: https://github.com/aiven/prometheus-exporter-plugin-for-opensearch/pull/204