Closed vijay2308 closed 9 months ago
I think the commits lacks DCO so the PR CI workflow will fail. If so, read up on how to fix this here.
Also, we might want to squash the commits before merging into main?
Can we have some attention on this? :) @lukas-vlcek
The issue was that OpenSearch 2.10.0 introduced some minor breaking changes (specifically, it moved some classes to different packages). See https://github.com/Aiven-Open/prometheus-exporter-plugin-for-opensearch/pull/230 for details.
Hi @vijay2308
thanks for the PR!
When it comes to cutting a new release we have a document (RELEASE_PROCESS.md) to help navigate through the process. We try not to include commits for OpenSearch upgrade and for README.md file update in a single PR. It is safer to make sure we first merge commit with OpenSearch upgrade (making sure CI jobs pass, in this case some coding was needed, see #230) and then we merge the commit with README.md file update which then becomes the "release commit" (it gets the git tag
and the repository should at this point in time include everything that is needed to replicate identical build that is found in the Release, see #232).
So, it is more practical to have two separate PRs.
As @vinylen pointed out we also require that all commits have their DCO. I know that for a simple update in markdown document this sounds like we are asking too much but it has its value. Imagine: what if in the future this plugin will get a chance to move under the same organization as OpenSearch itself or into its code base directly (for example when OpenSearch moves under independent foundation) then it will help if all commits are properly DCO signed.
Signing commits costs you nothing, just make sure you have the [user]
section in .git/config
file properly setup
and then use -s
option when doing a commit: git commit -s ...
.
This is what I have in my file:
$ cat .git/config
...
[user]
name = Lukáš Vlček
email = lukas.vlcek@aiven.io
...
I am closing this PR for now, please keep your PRs coming 👍
Upgrade the plugin to support Opensearch 2.10.0 Updates the documentation for plugin version 2.10.0.0
Opensearch 2.10.0 Release Notes
Description
Upgrade the plugin to support Opensearch 2.10.0 Updates the documentation for plugin version 2.10.0.0
Describe your PR and add links to relevant issues.
DCO stands for Developer Certificate of Origin and it is your declaration that your contribution is correctly attributed and licensed. Please read more about how to attach DCO to your commits here (spoiler alert: in most cases it is as simple as using
-s
option when doinggit commit
).Please be aware that commits without DCO will cause failure of PR CI workflow and can not be merged.