Closed Gokul-Radhakrishnan closed 11 months ago
Thanks @Gokul-Radhakrishnan for PR. It looks good, except we need to change two things:
- The commit needs to be signed (
git -s
). Please see the PR description for further info (the PR contains specific steps how you can sign the commit)- Please update the commit message and fix the version (2.1.1 -> 2.11.1, it is perhaps a typo)
Made the changes accordingly
Description
Describe your PR and add links to relevant issues.
DCO stands for Developer Certificate of Origin and it is your declaration that your contribution is correctly attributed and licensed. Please read more about how to attach DCO to your commits here (spoiler alert: in most cases it is as simple as using
-s
option when doinggit commit
).Please be aware that commits without DCO will cause failure of PR CI workflow and can not be merged.