search

Aiven-Open / tsc-output-parser

Parses errors from tsc output to a structured JSON format
Apache License 2.0
26 stars 5 forks source link

Add hashbang comment to cli.ts so it becomes executable #1

Closed aivenkimmob closed 3 years ago

aivenkimmob commented 3 years ago

The first release of this tool was missing the hashbang which is necessary to make it run with tsc-output-parser command. Without the hashbang, bash parses it as bash code which doesn't work.

aivenkimmob commented 3 years ago

The checks are failing because our eslint package is private. Solutions are:

  1. Make it public. I would recommend doing so because it allows us to release other open source modules which still depend on our internal styling rules

  2. Add NPM_TOKEN to GH actions and .npmrc to the repo