AizazSharif / smali

Automatically exported from code.google.com/p/smali
0 stars 0 forks source link

Error when recompile a dex file #70

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What seems to be the problem?

When I want to recompile the dex,smali shows me the following info:
======================== begin ========================
smali\com\maxmpz\audioplayer\widget\listwrappers\0xA1.smali[3,10] Error for inpu
t '"': Unterminated string literal
smali\com\maxmpz\audioplayer\widget\listwrappers\0xB5.smali[3,10] Error for inpu
t '"': Unterminated string literal
smali\com\maxmpz\audioplayer\widget\listwrappers\0xE9$1.smali[3,10] Error for in
put '"': Unterminated string literal
smali\com\maxmpz\audioplayer\widget\listwrappers\0xE9.smali[3,10] Error for inpu
t '"': Unterminated string literal
smali\com\maxmpz\audioplayer\widget\listwrappers\0XF$1.smali[3,10] Error for inp
ut '"': Unterminated string literal
......
......
......
======================== end ========================

What version of smali/baksmali are you using? What rom are you working
from?
The newest, v1.2.6

What dex?
In the attachment.

Original issue reported on code.google.com by ch3...@gmail.com on 2 Jun 2011 at 7:19

GoogleCodeExporter commented 9 years ago
Hmm. This one looks interesting :). I'll see if I can get it fixed over the 
weekend.

Thanks for the report!

Original comment by JesusFr...@gmail.com on 2 Jun 2011 at 2:20

GoogleCodeExporter commented 9 years ago
This is fixed in r811

Original comment by JesusFr...@gmail.com on 3 Jun 2011 at 1:42

GoogleCodeExporter commented 9 years ago
Good job supporting pirates.

Original comment by max...@gmail.com on 3 Jun 2011 at 5:14

GoogleCodeExporter commented 9 years ago
Hello,Max:
Google can search out pornographic content, can you say that Google is 
pornographic information dissemination engine?

Original comment by ch3...@gmail.com on 3 Jun 2011 at 4:12

GoogleCodeExporter commented 9 years ago
Go Pirates! Err, wait. I'm pretty sure I've publicly stated that I don't 
condone using smali/baksmali for piracy. I do agree that my tools can be (and 
often are) used for piracy. However, there are also many legitimate uses as 
well. Security research in particular comes to mind. I know for a fact that 
baksmali has been used to investigate some of the malware applications that 
have appeared on the market.

My goal is simply to provide the best tool possible. As such, when someone 
reports a bug, I fix it. And this was clearly a bug in the baksmali code, where 
it wasn't escaping the source file string correctly.

And even if I didn't fix this bug, it would be fairly trivial to automatically 
or even manually go through the files and fix up the escaping in the source 
file manually.

Original comment by JesusFr...@gmail.com on 3 Jun 2011 at 5:35

GoogleCodeExporter commented 9 years ago
Right, but poweramp is not a malware, ch3 is a pirate, and you do good and 
quick job supporting him. Nevertheless, smali still has bugs to exploit.

Original comment by max...@gmail.com on 15 Jul 2011 at 8:29

GoogleCodeExporter commented 9 years ago
A few points:

1. Sure, you assert that poweramp is not malware (and I believe you too). But 
from a security standpoint, does it make sense to trust your assertion? (Hint: 
the answer is no)

2. So it's a bad thing to provide quick bug fixes for a project? Interesting 
logic! :)

3. I don't contribute to/participate in/monitor the android piracy "scene". And 
as such, have never heard of "ch3". But even if I knew he is a pirate, it 
doesn't negate the fact that I fix bugs in my project when they are reported. 
Are you suggesting that I wait until the bug is reported by someone that is not 
a known pirate in order to fix it? Or maybe should I wait a week to fix bug 
reported by pirates? It almost sounds like I should hire a screening company to 
do an in-depth background check of every person that submits a bug report, to 
make sure they're not up to nefarious activities.

4. Yes, I'm sure there are still bugs in smali/baksmali :). I'm not naive 
enough to claim otherwise.

Original comment by jesusfreke@jesusfreke.com on 15 Jul 2011 at 9:44