Aizistral-Studios / Enigmatic-Legacy

Remains of the former Minecraftian times.
https://www.curseforge.com/minecraft/mc-mods/enigmatic-legacy
Other
81 stars 48 forks source link

[Compatibility] Pearl of the void #422

Open azukaar opened 1 year ago

azukaar commented 1 year ago

Pearl of the void due to its disabling all status effect mechanism, makes a lot of mods that rely on status effect to make non-status-effect stuff completely useless. I'm thinking about things such as:

While I understand the idea of cancelling effects, I think that may be making so many mods obselete by cancelling their effect, especially everlasting abilities (i mean.. Everlasting is in the title, no? :D)

I'm proposing a solution to ignore any effect whose duration is either infinite (for newer mods) or < 2sec (for older mods that just repeat the effect before infinite timer were a thing)

If that interaction is intended please ignore and close the ticket

Aizistral commented 1 year ago

While I was aware of this interaction when I implemented Pearl of the Void, it is not necessarily something I want. The problem is that even with infinite effects, there is no guarantee that just because the effect is infinite, it comes from an accessory or something else just uses status effect as a proxy. Likewise, not all mods that have proxy effects with non-inifnite timers keep their duration under 2 seconds, in my experience that duration seems to vary a lot between different mods and items.

azukaar commented 1 year ago

I supposed that it's true! Another alternative would be cure the effect like 3 times and if it comes back immediately everytime, assume it is actually a inventory item proxy?