Decrypt encrypted messages with encryption disabled

Aizistral-Studios / No-Chat-Reports

Disable Player Chat Reporting and make user messages untrackable.

https://modrinth.com/mod/no-chat-reports

Do What The F*ck You Want To Public License

950 stars 78 forks source link

Decrypt encrypted messages with encryption disabled #304

Open Edgeburn opened 2 years ago

Edgeburn commented 2 years ago

Idea

The mod should attempt to decrypt encrypted messages with the set key, even if the user has message encryption disabled. This would be nice so that a conversation in encrypted messages can be initiated without first needing to tell the other person to enable encryption.

Reasoning

No response

Other Information

No response

Madis0 commented 2 years ago

I really don't think keeping decryption enabled at all times is a good idea...

Description may be non-trivial for some devices/algorithms, meaning it will consume a non-zero amount of system resources
The user seeing this will still have their messages written in plaintext, so it's kind of a false sense of security
This feature would still be useless/waste of resources when the other parties' key or algorithm changes

Instead I think the idea of #245 would be better - automatically enabling certain algorithm/key per server.

Or, if awareness is the goal, maybe it would be more trivial for NCR to just detect and mention that "this message may be encrypted, try enabling encryption to read it".

Edgeburn commented 2 years ago

Perhaps it should be a config option that could be enabled or disabled?

Or, if awareness is the goal, maybe it would be more trivial for NCR to just detect and mention that "this message may be encrypted, try enabling encryption to read it".

Unfortunately, the problem with this is that there's no way to decrypt the existing message as far as I'm aware (at least in-game)

mylesbartlett72 commented 1 year ago

What about an encryption mode, where you can click the lock icon (the encryption toggle) and it cycles between no encryption or decryption, encryption and decryption enabled, and now no encryption but decrypt incoming?

Madis0 commented 1 year ago

No matter how the toggle worked, it still seems to increase convenience at the expense of user security, because the receiving ends would be implicitly more vulnerable than before (because they'd not encrypt by default while reading messages of those who do). How would you solve that issue?

IlyaYezelovsky commented 1 year ago

I think someone can make a tool that can decrypt not in-game. What about a tool to copy the message?