search

Aizistral-Studios / No-Chat-Reports

Disable Player Chat Reporting and make user messages untrackable.
https://modrinth.com/mod/no-chat-reports
Do What The F*ck You Want To Public License
950 stars 78 forks source link

"demandOnClient" isn't respected while hosting with Essential Mod #370

Open andrew2240e opened 1 year ago

andrew2240e commented 1 year ago

Modloader

Fabric

Minecraft Version

1.19.3

Modloader Version

Fabric: Loader 0.14.16

No Chat Reports Version

1.19.3-v2.0.0

Modpack Info

No response

The latest.log File

No response

Bug Description

demandOnClient isn't respected while hosting your multiplayer world with Essential Mod.

Steps to Reproduce

  1. Install Essential Mod and No Chat Reports
  2. Host world with Essential Mod

When your friend tries to join, (even if "demandOnClient" in 'NCR-Common.json' is set to false) it will kick them for not having No Chat Reports installed.

Other Information

Please tell me if this is just user error lol

Aizistral commented 1 year ago

Unfortunately I cannot verify this issue myself, as doing so would require me to agree to Essential's dedicated Terms of Service and Privacy Policy, which I am not willing to do. Furthermore, the mod itself uses custom distribution system where the actual contents of the mod are downloaded from their own servers, which means that third-party platforms such as CurseForge and Modrinth cannot verify that these contents are non-malicious. Overall, I consider Essential to be an incredibly shady mod, and I do not recommend that you use it, for the purpose of hosting worlds or any other. I remain willing to make adjustments to No Chat Reports in order to alleviate compatibility issues, but someone else would have to figure out what is causing them.

andrew2240e commented 1 year ago

It’s probably something to do with LAN play since that’s how Essential Mod’s hosting works.

On Wed, May 17, 2023 at 9:14 AM Aizistral @.***> wrote:

Unfortunately I cannot verify this issue myself, as doing so would require me to agree to Essential's dedicated Terms of Service https://essential.gg/terms-of-use and Privacy Policy https://essential.gg/privacy-policy, which I am not willing to do. Furthermore, the mod itself uses custom distribution system where the actual contents of the mod are downloaded from their own servers, which means that third-party platforms such as CurseForge and Modrinth cannot verify that these contents are non-malicious. Overall, I consider Essential to be an incredibly shady mod, and I do not recommend that you use it, for the purpose of hosting worlds or any other. I remain willing to make adjustments to No Chat Reports in order to alleviate compatibility issues, but someone else would have to figure out what is causing them.

— Reply to this email directly, view it on GitHub https://github.com/Aizistral-Studios/No-Chat-Reports/issues/370#issuecomment-1551372227, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYHE3WYEC7M77P64DOIVJ73XGTFLVANCNFSM6AAAAAAVZ5GBK4 . You are receiving this because you authored the thread.Message ID: @.***>

Aizistral commented 1 year ago

It’s probably something to do with LAN play since that’s how Essential Mod’s hosting works.

My efforts to reproduce this in a standard LAN session were unsuccessful, the config works as expected.

andrew2240e commented 1 year ago

You tried between one client that has NoChatReports and one that doesn’t?

On Wed, May 17, 2023 at 9:36 AM Aizistral @.***> wrote:

It’s probably something to do with LAN play since that’s how Essential Mod’s hosting works.

My efforts to reproduce this in a standard LAN session were unsuccessful, the config works as expected.

— Reply to this email directly, view it on GitHub https://github.com/Aizistral-Studios/No-Chat-Reports/issues/370#issuecomment-1551413535, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYHE3W4MO7BNLX3445XKGWDXGTH5XANCNFSM6AAAAAAVZ5GBK4 . You are receiving this because you authored the thread.Message ID: @.***>

Aizistral commented 1 year ago

You tried between one client that has NoChatReports and one that doesn’t?

Naturally. Setting demandOnClient to true on No Chat Reports client responsible for hosting the world prevented the other client without No Chat Reports from joining the world, and setting it to false allowed the client to join with no issues. Your could attempt the same test to ensure the issue indeed only happens with Essential, hosting a LAN world via standard means does not require that you use online accounts.