Aizistral-Studios / No-Chat-Reports

Disable Player Chat Reporting and make user messages untrackable.
https://modrinth.com/mod/no-chat-reports
Do What The F*ck You Want To Public License
950 stars 78 forks source link

Backport to 1.19.2 #401

Open itsdinkd opened 1 year ago

itsdinkd commented 1 year ago

Idea

You have fixed tons of issues with NoChatreports on mc 1.19.3, and 1.19.4

However, majority of your userbase is still on 1.19.2 (Due to all major modpacks being on 1.19.2 and not the other .3 and .4 versions, except for "optimization client side modpacks").

Please backport 2.X to 1.19.2 Fabric.

See downloads

Notice 1.19.2 with 51k, and all the other versions for higher MC versions do not come close. image

2.5m for 1.19.2 all higher versions do not come close. Most of your users are on 1.19.2 image

Madis0 commented 1 year ago

Keep in mind that chat signing on 1.19.2 works very differently from 1.19.3 and up, so not everything can be ported or it wouldn't make sense to do so in the same way. Maybe you should be more specific on what features would you even like a backport for?

Aizistral commented 1 year ago

I am aware that most of the users are still on 1.19.2. In fact, it seems that final 1.19.2 releases constitute the majority of mod's total downloads at this time. Due to this I am willing to make an exception and make a few updates for 1.19.2.

But as @Madis0 correctly stated, chat signing works very differently from 1.19.3 and onward, so most bugfixes and feature updates simply cannot be backported as is. I am open for suggestions on what should be backported and how.

IlyaYezelovsky commented 1 year ago

It seems like a good idea, but I always use Forge :)

Aizistral commented 1 year ago

It seems like a good idea, but I always use Forge :)

Yeah, this would definitely not be specific to Fabric if I ever do it.