search

Aizistral-Studios / No-Chat-Reports

Disable Player Chat Reporting and make user messages untrackable.
https://modrinth.com/mod/no-chat-reports
Do What The F*ck You Want To Public License
949 stars 78 forks source link

Does not fetch signatures when installed clientside on Quilt #423

Open NoSadBeHappy opened 1 year ago

NoSadBeHappy commented 1 year ago

Modloader

Quilt

Minecraft Version

1.20.1

Modloader Version

0.19.2

No Chat Reports Version

1.20.1-v2.2.2

Modpack Info

https://modrinth.com/modpack/sodiumplus

The latest.log File

https://gist.github.com/NoSadBeHappy/43ea1b31f6fe58ce50e9578158ad7eab

Bug Description

When chatting in my server, the server kicks me even if I have it set to allow chat reports.

Steps to Reproduce

  1. join any server
  2. set no chat reports to always, meaning it allows chat reporting
  3. say something in chat
  4. get kicked

Other Information

Madis0 commented 1 year ago

Set your server up properly. https://github.com/Aizistral-Studios/No-Chat-Reports/wiki/Protecting-Server-Players

NoSadBeHappy commented 1 year ago

I have, I installed liberated chat.

Madis0 commented 1 year ago

But did you change the server properties as needed?

NoSadBeHappy commented 1 year ago

Yes. I said so in the og issue

Madis0 commented 1 year ago

Then I'd assume it is caused by EssentialsXChat, try disabling that.

Aizistral commented 1 year ago

Then I'd assume it is caused by EssentialsXChat, try disabling that.

Let me reassure you that I am not unwilling to fix plugin compatibility issues, and in fact, I have done so in the past. However, I require a conclusive report that specifies exactly which plugin causes the issue and under what circurmstances, so that I may reproduce it myself and figure out what action would be appropriate on our side regarding this, if any. @NoSadBeHappy, I ask you to isolate the issue to the extent of your ability and specify every single relevant detail pertaining to it, so that I may aid in its long-term resolution.

Aizistral commented 1 year ago

Sorry for accidental closure, misclicked.

NoSadBeHappy commented 1 year ago

I don't think this is because of essentialsx chat. I have tried on a different server, and I have the same problem. As you can see in my server.properties, enforce-secure-profile is off, and here are my plugins, image and I still have the same issue. When adding liberated-chat, I still have the same issue no matter what mode no-chat-reports is on. Due to this, I believe that my issue is most likely due to other mods I have, so I have sent all of my config, logs, crash-reports, and mods folders inside my .minecraft folder below. This is mostly sodium plus, as I said in the og issue, but I have added a couple of mods to it. (yes im aware I should have sensored my ip adress.) I am happy to supply any extra information to help you get this resolved, and thank you very much for your help.

.minecraft.zip https://drive.google.com/file/d/1AL3oglOEkmBa0nNwUi4LgUV_9NjJsspW/view?usp=sharing

Madis0 commented 1 year ago

Your clientside mods barely matter. Once you have NCR, the signing is already avoided and it is the server that kicks you. That's why I still think it has something to do with server configuration. The plugins you isolated yourself to seem irrelevant, but Purpur itself has a lot of options, try looking over those that related to chat or signing/signatures.

IlyaYezelovsky commented 1 year ago

I think you should replace LiberatedChat with FreedomChat. My server also uses EssentialsXChat (and FreedomChat), but this issue did not occur. In addition, I am using the Forge 1.20.1 client and the server is Leaves. And, why you use Minecraft 1.19.1 with NCR 1.20.1?

NoSadBeHappy commented 1 year ago

The reason I think it is my client is because it kicks even when I allow no chat reports to send reports. I will try freedomchat though.

NoSadBeHappy commented 1 year ago

Also, @IlyaIvanovsky I am using Minecraft 1.20.1, you can see in the log.

IlyaYezelovsky commented 1 year ago

Also, @IlyaIvanovsky I am using Minecraft 1.20.1, you can see in the log.

Please edit your issue. "Minecraft Version" is wrong.

NoSadBeHappy commented 1 year ago

Also, @IlyaIvanovsky I am using Minecraft 1.20.1, you can see in the log.

Please edit your issue. "Minecraft Version" is wrong.

Sorry, your right. Edited now.

RedstoneWizard08 commented 1 year ago

Shouldn't this work with vanilla servers, though? It used to auto-disable, and this is an issue with Sodium Plus (the client), not the server. The server config shouldn't matter. Has this been tested on vanilla servers? The same thing happened to me.

Madis0 commented 1 year ago

By the symptoms, this may be an issue with the way NCR interacts with the Quilt client, so the signatures may not be fetched in the first place. Aizistral has said he'll have a look at it.

jan-Sanku commented 11 months ago

I'm having this issue as well.

By the symptoms, this may be an issue with the way NCR interacts with the Quilt client, so the signatures may not be fetched in the first place. Aizistral has said he'll have a look at it.

Indeed, I was kicked off vanilla servers with enforce-secure-profile=false using NCR on Quilt, regardless of NCR settings. Switched to Fabric and it works even with signatures forced on. I hope that's useful in some way.

CompeyDev commented 10 months ago

Facing the same issue on my client while using the Quilt loader all the time. Can confirm.

CompeyDev commented 10 months ago

Any updates or potential fixes? CC @Madis0 @Aizistral

NoSadBeHappy commented 10 months ago

Unfortunately as far as I know there isn't.

CompeyDev commented 10 months ago

I was speaking on the technical side of things, whether a potential fix has been identified in the mod itself; not on the users' side!

RedstoneWizard08 commented 9 months ago

For now I'm moving Sodium Plus over to Fabric from Quilt, but this issue still needs to be fixed.

jan-Sanku commented 8 months ago

I feel like new versions of NCR should not be tagged as compatible with Quilt on Modrinth until this is fixed, because it's currently not really usable on Quilt.

Madis0 commented 8 months ago

Per request, 1.20+ versions no longer have the Quilt marking. If you can reproduce it in earlier versions, let us know.

CompeyDev commented 8 months ago

Temporarily, that works, but it would be better to have this issue sorted out in the future. Been using fabric for a couple months instead of quilt which isn't ideal, since there's some mods I simply cannot use.

jan-Sanku commented 2 months ago

any updates on this one? i see this has the "3rd party" label now, is there anyone in particular this needs to be reported to?