Aizistral-Studios / No-Chat-Reports

Disable Player Chat Reporting and make user messages untrackable.
https://modrinth.com/mod/no-chat-reports
Do What The F*ck You Want To Public License
950 stars 78 forks source link

Detect and mark servers that enforce but prevent chat reports #437

Open Madis0 opened 1 year ago

Madis0 commented 1 year ago

Idea

In 1.20.2, the server-side toast removal was done. We discussed this and it seemed like a sensible thing to do.

However, as a result there may now be servers that both enforce chat signing at the server level and prevent chat signing at chat conversion level. NCR should account for this and show the proper indicator/tooltips by that.

Reasoning

Described above

Other Information

It probably needs new tooltips, but I'm not sure if it needs a new icon - could reuse the yellow one. The reliability of such indicator is also a bit questionable, but I still think it is possible:

Edit: I forgot the part where NCR announces the green state, in this case - if the two heuristics are met - the state can be shown as green.

Related to #177 but it is more theoretically described there

Madis0 commented 1 year ago

Well, right now this can't be done with NCR as it will force enforce-secure-profile off, even if it's not disabled in server properties But it's a thing The main problem with a setup like this is that the client has to trust the server that signatures are stripped, and not, say, stored by the server or only relayed to specific players

  • Aizistral

So maybe reusing green or yellow is not the best idea... It is still an unique state to indicate and arguably less dangerous than the normal enforced signature state. But because the client essentially loses control and only sees what the server tells, it is a matter of trust.

Secret-chest commented 1 year ago

Orange exclamation sign?

Madis0 commented 1 year ago

Orange exclamation sign?

I thought of something like that - a yellow or orange exclamation sign of some kind.

But that would still be a lose-lose situation: the user may not notice the difference between yellow/orange and red exclamation sign and the server doesn't get to show a good status to the user, despite their (likely) best intentions to disable chat reporting and annoying warning.

Madis0 commented 1 year ago

Anyway, initial tooltip idea:

This server appears to prevent chat reports. However, it also requires signatures from players. This could either be for simply removing the warning from vanilla users, or for allowing chat reporting (for your chat) by a limited set of users, such as admins. Proceed with caution.

Perhaps initially it can use the same "insecure" icon with just a changed tooltip.

IlyaYezelovsky commented 9 months ago

以上字段的简体中文翻译(Simplified Chinese translation)应为:

此服务器似乎禁用了聊天举报。然而,它也要求玩家发送已签名的消息。这可能是为了防止原版客户端在加入服务器时显示警告弹窗,也可能是为了允许部分用户(如管理员)举报玩家的消息。请小心操作。