search

Aizistral-Studios / No-Chat-Reports

Disable Player Chat Reporting and make user messages untrackable.
https://modrinth.com/mod/no-chat-reports
Do What The F*ck You Want To Public License
950 stars 78 forks source link

Improvements to the Readme #469

Closed christopherplaysminecraft closed 7 months ago

christopherplaysminecraft commented 8 months ago

This is a bit easier to read and makes it a bit "smoother"

I have also made the "Configuration" part it's own section, to give people an easy to find and short explanation of what each file does.

For some reason GitHub makes my changes look big, which is not the case.

christopherplaysminecraft commented 8 months ago

Also removed the mentioning of Mojang Accounts, as those don't really exist anymore.

christopherplaysminecraft commented 7 months ago

Ok, I think I got kinda confused there and would like to clarify. You said that player reporting got added in 1.19.1, then why does NoChatReports have releases for 1.19.0?

Madis0 commented 7 months ago

Ok, I think I got kinda confused there and would like to clarify. You said that player reporting got added in 1.19.1, then why does NoChatReports have releases for 1.19.0?

Chat signing was added in 1.19.0. At the time, nobody knew how it would be used and didn't think much of it (as it sounded positive in theory). But when the 1.19.1 snapshots and pre-releases came, NCR was made, including for 1.19 just in case (it was also not known if 1.19.1 users can report 1.19 ones).

christopherplaysminecraft commented 7 months ago

Shouldn't those two say "1.19" then?

This mod strips cryptographic signatures which are attached to every chat message sent from

Disables Player Chat Reporting from

You did say that Player reporting was added in 1.19.1, not 1.19 though

Madis0 commented 7 months ago

This mod strips cryptographic signatures which are attached to every chat message sent from

Yes, 1.19 had signatures that NCR prevents, so you could change it.

Disables Player Chat Reporting from

However 1.19.1 users could not report 1.19 ones (and vice-versa), so chat reporting was kind of irrelevant there. The 1.19 signatures were just removed as a precaution, not sure how to word that.

christopherplaysminecraft commented 7 months ago

Well, 1.19 users can still report 1.19 users and 1.19.1 ones other >=1.19.1 (1.19.2, .3, .4 and 1.20+) users, right?

So maybe something like:

Madis0 commented 7 months ago

1.19 users cannot report anyone, the button, dialogs and other technicalities were added in 1.19.1, hence the controversy there.

christopherplaysminecraft commented 7 months ago

So you're saying that they just added signatures and all just to not give users the ability to even use them? That's.. wow.

What about this

Disables Chat Reporting from 1.19.1 and onwards Also removes Signatures on 1.19 as a security measure, even though the ability to report players only got added in 1.19.1

Madis0 commented 7 months ago

Well, signing messages generally is a matter of authenticity, so one could assume it to be implemented for a good cause, like a prerequisite for end-to-end encryption, or even just for preventing servers from modifying/spoofing player messages (which was indeed added).

Anyway - yes, your suggested paragraph looks fine.

christopherplaysminecraft commented 7 months ago

Is this enough? Didn't want to make it too long..

christopherplaysminecraft commented 7 months ago

Btw any idea on when this will be merged?

Aizistral commented 7 months ago

Btw any idea on when this will be merged?

Right about now 👌

christopherplaysminecraft commented 7 months ago

Whoops, literally asked 5 minutes before it got merged....

Aizistral commented 7 months ago

Whoops, literally asked 5 minutes before it got merged....

Well actually I saw your comment and realized that this is probably ready to be merged, so, like, I merged it 😅