Should this library be linked?

Ajackster / react-native-global-props

A simple javascript implementation to add custom, default props to react-native components.

MIT License

350 stars 33 forks source link

Should this library be linked? #13

Closed lebedev closed 6 years ago

lebedev commented 6 years ago

There're ios and android folders in this repo, and this library links automatically if react-native link command is run. However, In my project it isn't linked, and... it works just fine? At least the subset of features that I use.

Can you describe for what functionality should this library be linked? Are these from the example, maybe?

shukerullah commented 6 years ago

This is very annoying whenever I run react-native link command, this library is linked.

mCodex commented 6 years ago

Yes, I think it should be linked. I'm currently using RN 0.57 and what I've done so far is: react-native link react-native-global-props and then I go to Xcode and then:

Click in my project
Go to Build Phases
Click in Link Binary With Libraries
Remove ReactNativeGlobalProps.app and ReactNativeGlobalProps.test (something like that) And build

lebedev commented 6 years ago

@mCodex why linking and then removing? Wasn't it working before you linked it?

maieonbrix commented 6 years ago

@Ajackster can we delete those folders ?

Ajackster commented 6 years ago

@maieonbrix Yeah, we can remove them. I think I made this project using the react-native init command which included a bunch of files that can be removed since this library is just a couple utility functions.

maieonbrix commented 6 years ago

I am on it, will open a PR in the following hours

Ajackster commented 6 years ago

Awesome, thanks :)