Ajapaik / ajapaik-web

Crowdsourcing of data for historic imagery (geotagging, face tagging, rephotography)
https://ajapaik.ee
GNU General Public License v3.0
27 stars 19 forks source link

#79 Add Markdown toolbar for new comment, reply and edit fields #95

Closed blimly closed 2 years ago

blimly commented 2 years ago

preview

MaertHaekkinen commented 2 years ago

I noticed that the Editor is not available when editing a comment.

How to reproduce the issue:

1) Save a new comment 2) Edit comment 3) Save edited comment 4) Try to edit the comment once more

Observed result: No toolbar visible Expected result: Toolbar is visible and text can be edited as before.

MaertHaekkinen commented 2 years ago

I noticed that when copy-pasting content into the comment box, then the comment can't be saved. A validation error is shown.

image

How to reproduce the issue

1) Copy-paste a value to comment box 2) Click send

Observed result: The comment is not saved, a validation error is shown Expected result: The comment is saved

blimly commented 2 years ago

Re-editing and pasting should work now

codecov[bot] commented 2 years ago

Codecov Report

Merging #95 (dabb03e) into master (a4f2fe0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   15.68%   15.68%           
=======================================
  Files         160      160           
  Lines       10876    10876           
=======================================
  Hits         1706     1706           
  Misses       9170     9170           
Flag Coverage Δ
unittests 15.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4f2fe0...dabb03e. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication