search

Ajarmar / universal-pokemon-randomizer-zx

Public repository of source code for the Universal Pokemon Randomizer ZX
GNU General Public License v3.0
593 stars 152 forks source link

[Bug] NPC Ethan/Lyra's (HGSS) Pokemon is random for unknown reason. #752

Open HappyFaceSpider opened 4 months ago

HappyFaceSpider commented 4 months ago

Describe the bug In HGSS the 'Best Friend' character (i.e. Ethan if player is girl and Lyra if player is boy) should have a Marill. However after I used the Randomizer Ethan/Lyra's pokemon got randomized too (Umbreon in one attempt, Grotle in another). However the only setting i picked in the Randomizer was "Change Impossible Evolutions", so I don't think any NPC's pokemon should've been randomised. Is it a bug or did I simply do something wrong? Or is this normal? I'm worried that it means other NPC's pokemon also got randomised.

To Reproduce Steps to reproduce the behavior:

  1. Load Pokemon SoulSilver ROM into Randomizer
  2. Check "Change Impossible Evolutions"
  3. Save new ROM
  4. Launch new ROM

Expected behavior I expected Ethan/Lyra to still have Marill and only trade evolutions of some pokemon to be changed.

Screenshots EthanHasGrotle

I'm attaching log from the Randomizer. Pokemon - SoulSilver MYMOD.nds.log

System (please complete the following information):

Additional context So, this is my first time using the randomizer, so it's possible I simply f*cked something up.

MogenarZ commented 4 months ago

I encountered this same issue - similarly, I only checked "Change Impossible Evolutions".

Xero-IX commented 3 months ago

Just wanted to add that I encountered the same issue with the same settings. I tried to adjust the settings a second time but got the same thing: first time was Blastoise, second was Girafarig. Did you notice any other problems with the playthrough or should I just run it as is?

Fellshadow commented 3 months ago

this isn't a bug, the randomizer deliberately always randomizes ethan/lyra's pokemon to indicate that the rom has gone through the randomizer program In other games like FRLG it's the pokemon the professor throws out in the intro of the game that always gets randomized for this purpose, i'm not sure why they decided to use ethan/lyra's pokemon here for HGSS instead of the pokemon oak throws out in the intro but it's a deliberate choice rather than a bug

bellonarius commented 2 months ago

Is it possible to remove this particular randomizing? Imo it would be better to have prof. Oak show us a different Pokemon, because it is kinda weird to see Lyra or Ethan walking around with a Milotic or a Slaking at the start and other encounters

Syddraf commented 2 months ago

Would like to second the request to remove this. Seems like an odd choice to force Ethan's / Lyra's Pokémon being randomised on people.

Maximum-beans commented 2 months ago

I've finally found people who've encountered the same thing! I'd also like to voice support for changing this. It could have easily been done to the Marill that Oak shows in the intro. An odd choice, I agree.

faizjamil commented 1 month ago

Yeah I agree this is an odd choice, but that might be cause I lack a reason for this behavior. Granted I only use this program for non-randomizer related patches. Mainly to patch out the impossible evolutions. If this isn't the right patcher to use for that then I'd like to know where I can get a patch and patcher for dealing with the trading evolutions. Only workaround I've found is to use an older version of this randomizer program

MogenarZ commented 1 month ago

Yeah I agree this is an odd choice, but that might be cause I lack a reason for this behavior. Granted I only use this program for non-randomizer related patches. Mainly to patch out the impossible evolutions. If this isn't the right patcher to use for that then I'd like to know where I can get a patch and patcher for dealing with the trading evolutions. Only workaround I've found is to use an older version of this randomizer program

I ended up using the DSPRE, which has a fairly intuitive evolution editor built in now. Making all the evolution changes manually is a bit tedious, but it only has to be done once

CroixJeremy2 commented 6 days ago

Hello, I also would like to change this option (or maybe make it available in a "tick box" in the randomizer at least), because I really would also like the default Marill... I checked where in the code you implemented this change. It is in: com -> dabomstew -> pkrandom -> romhandlers -> Gen4RomHandler.java -> from line 4776 to line 4829.

I can delete those lines myself after having downloaded the universal-pokemon-randomizer-zx-master.zip file, but I have absolutely not any knowledge on how to make then the a new .jar file afterwards... I tried to download the latest .jar myself but I realised that it is now a .class file (not a .java that I edit myself). So, from what I have understood, a decompiler/editor tool is required. I tried myself with recaf-gui-0.5.3.jar, but when I try to save after having deleted the lines of interest, there are multiple errors elsewhere that I don't know how to solve... I think this is really a feature that only people that have already good knowledge of how to handle .java files and compilers can do unfortunately for us damned mortals. Could the dev change this feature please? or could anybody with those required skills tell us step by step how to do it please?

Thanks in advance for your response, Best regards,