Sub2Srs Search and Cropro

[cd-FileX]

So, as I more or less mentioned in my pull request, I have created a project out of Cropro called Sub2Srs Search. It is taking the basic functionalities of cropro and modifying it in a way you can search cards from an API instead of a collection. Now, as I also use this as one of my daily use addons, I wanted to integrate the other-collection-search-functionality into SubSearch. (This is just a thought I had, haven't planned anything yet and still got my pull request here to fulfill)

Though, as this would knock out cropro, stealing it's functionality and topping it twice, or if the other way around Subsearch being merged into cropro after just 2 months (+ me losing my only addon), I wanted to ask what your best solution for this would be?

The reason behind the wish to implement it instead of having two addons is simply the easiness of finding cards. If you have set up both like me, there are decks not in Immersion Kit (the API SubSearch uses) but which I have found online. So to not have to enter the same word in both windows, having to close the one and reopen the other if on Windows, this was my easiest solution. On top, there would be no need for pushing back and forth updates.

[tatsumoto-ren]

I'm going to add immersionkit search to cropro when I have time. But it needs to have a button to switch between a remote search and a local search functions.

[cd-FileX]

I didn't mean it that way. I think it should be possible to search both at the same time. If you add a button for this function, there is no sense of adding the one add-on to the other. My goal here is to mix those two together, giving the user a kind of ability to add decks to the API, though without modifying it. Also I asked because of the fact I don't like knocking out other addons especially without any chance for the author to contribute or directly say what he wants/thinks.

[tatsumoto-ren]

I think it should be possible to search both at the same time.

That's possible but will be confusing because it will cause local results and remote results to be mixed. And since the process of importing remote notes and local notes is different, it will complicate the logic. So my idea was to treat immersionkit essentially like a different profile (collection) to search in.

I'm currently in the process of refactoring CroPro to make it easier to add the remote search feature on top of the existing features. But can't promise anything yet.

[cd-FileX]

Though that makes sense, I think it would be easier to be implemented in the way of Cropro -> SubSearch, as I am having an open logic over there, mostly not basing on special collection bases. Also you're nailing on the SubSearch -> CroPro implementation like my addon would be a threat for you. For sure, it could have gotten one if I would have implemented this straight away in my addon, but as I said before, that's why I asked.

Currently, I rather feel that you want to eliminate my addon as soon as possible to put yours in it's place.

[tatsumoto-ren]

You have the freedom to change the source code of any GPL program to make it do what you wish. This is one of the four essential freedoms.

But I think that what you did was not nice because working jointly on a single add-on would benefit everybody. At Ajatt-Tools we believe that all software for language learning should be accessible in one place, that's why we invite other people to our organization and encourage them to transfer their repos instead of trying to separate their efforts from ours.

[cd-FileX]

My addon was, though in a way similar with Cropro, basing on different things, that's why I created a new one. It was just the base that was remaining of cropro. Also, if you believe people should transfer their repositories to your organization, it seems like a bit too less encouragement to me, to get people to that goal, and in this case rather like a "let me just quickly take your repository". (btw the repository is on codeberg, so not able to be transferred) Though I also think, the resources should be available openly and at one place, I see your approach to this a bit too strict, singularity-oriented and not open-minded.

With this being said, I am fine with being invited to your group instead of dragged and fine with your addon taking over mine, however, I would like to be able to do some implementations and develop the addon or addon part further, rather not behind a pull request but direct. As this is a pretty big thing I myself wouldn't let another do so easily, I am fine with any code reviewing or direct help.

[tatsumoto-ren]

Ajatt-Tools is a joint effort. We have this organization on GitHub and don't use personal accounts to host our repositories. We are trying bring all software for language learning in one place. Under one organization. When everything is in one place, it's easy to find software and it's easy to help each other. So the phrase "let me just quickly take your repository" is not correct. Our organization is the opposite of that.

Please join our chat if you want to contribute.

Regarding your fork of CroPro, I think it's better keep it available on AnkiWeb at least until we catch up and merge its features into this repo.

[cd-FileX]

はいはい, got it. Though I still would prefer being asked before, I already joined the chat though was to lazy yet to create an account outside of matrix.org even though that somewhat seems contradictory with the rest and somewhat weird. If you don't mind, would you write me a private message @filex:matrix.org?