search

Ajatt-Tools / learn-now-button

🍝 Put cards in the learning queue and answer cards from the Card Browser.
https://ankiweb.net/shared/info/1021636467
GNU Affero General Public License v3.0
8 stars 2 forks source link

FSRS Compatibility (Learn Now & Grade Now) #2

Closed Exponent4806 closed 9 months ago

Exponent4806 commented 1 year ago

I started a discussion about the compatibility of this add-on with FSRS:

https://github.com/open-spaced-repetition/fsrs4anki/issues/540

Could you please help us to clarify this issue ?

It seems that the add-on is partially compatible, but I am not completely sure. It seems that using your add-on with the new algorithm FSRS might cause serious problems, and there is no warning about that.

tatsumoto-ren commented 1 year ago

Could you please help us to clarify this issue ?

Looks like there's a bug in FSRS that prevents the add-on from being compatible. FSRS has to initialize the initial memory state when the card is learned but it fails to do so if a card was moved to the learning queue manually.

KAGEYAM4 commented 9 months ago

This got implemented https://github.com/ankitects/anki/commit/db93939ded947d74bb25bd8552a2b2356a096509