search

AjayArvind2207 / pe

0 stars 0 forks source link

Inappropriate error message in entering invalid email #3

Open AjayArvind2207 opened 5 months ago

AjayArvind2207 commented 5 months ago

I attempted to enter the email c--de@de.com and it correctly prevented me from doing so. However, the error message I get tells me the following:

Emails should be of the format local-part@domain and adhere to the following constraints:

  1. The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (+_.-). The local-part may not start or end with any special characters.

Here, the local part does indeed only contain alphanumeric characters and special characters among those, and it does not start or end with special characters. So according to the error message, this is a valid local-part. However, since it has consecutive special characters, it is correctly deemed invalid.

nus-pe-script commented 5 months ago

Team's Response

This is the same issue pertaining to a lack of clarity within the documentations.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inconsistent message in the error message when entering an incorrect email.

I entered the following email: a@b..c It correctly raised an error. However, I noticed something about the error message. In point 2, it says that the domain labels are separated by periods

This is followed by a '@' and then a domain name. The domain name is made up of domain labels separated by periods.

However, in the part proceeding that, in the last bullet point, it says that each domain label should only separated by hyphens.

``The domain name must:

  • end with a domain label at least 2 characters long
  • have each domain label start and end with alphanumeric characters
  • have each domain label consist of alphanumeric characters, separated only by hyphens, if any.``

This is inconsistent, and could perhaps be phrased better if it was trying to say that domain labels can contain hyphens.

[original: nus-cs2103-AY2324S2/pe-interim#5467] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** Thank you for the feedback! This is certainly not a very low bug because it is not an aesthetic bug. On the contrary, it is an undescriptive error message which is far more than just a visual bug. Hence I will be sticking to my original severity of low.