search

AjayArvind2207 / pe

0 stars 0 forks source link

Inappropriate error message when trying to delete an index which does not exist. #6

Open AjayArvind2207 opened 2 months ago

AjayArvind2207 commented 2 months ago

I ran the following commands with 10 entries: delete 11

image.png

delete 0

image.png

It would perhaps make more sense to have the error message of the second command be similar to that of the first, considering both of them have the same issue of being out of bounds.

nus-pe-bot commented 2 months ago

Team's Response

Although it is true that both are about the out of bounds issue, both error messages correctly point out the requirement for index. We do not think this affects the app's features.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response! While it is certainly not a dealbreaker, I still believe this to be a slightly weaker error message, since from the perspective of new users using the app, perhaps someone who is a programmer and works often with zero-based indexing, it would be far more explanatory to say the index is invalid, than the entire command format being invalid.