search

AjayShanker-geek / pe

0 stars 0 forks source link

Contact Manager shows `ILLEGAL` with same input #4

Open AjayShanker-geek opened 2 weeks ago

AjayShanker-geek commented 2 weeks ago

Describe the bug

First input will flag as ILLEGAL then will allow again after same input.

To Reproduce

  1. Select 1 to enter Contact Manager mode
  2. This will flag it as ILLEGAL: add /name:a /phone: qwertyur
  3. Try again and allow: add /name:a /phone: qwertyur

Expected behavior

Same input should show consistent outcome.

Screenshots

Screenshot 2024-11-15 at 4.40.28 PM.png Screenshot 2024-11-15 at 4.40.58 PM.png

Desktop

nus-pe-script commented 1 week ago

Team's Response

Thank you for bringing this up, it seems that there is a spacing issue in your second input which caused the error. Hence it is not an issue with the adding of contacts that is inconsistent. However, this definitely could be improved on from our side hence we will accept it as an issue of low severity.

Additionally, these factors were considered in assigning the severity (LOW):

  1. it does not cause the app to crash
  2. Users can easily just remove the space

Additionally, this is a duplicated issue since all functionalities are under the same parser class and adding a .trim() before the function processCommand() would fix everything in all of the duplicated issues

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]