search

Ajneb97 / PlayerKits

https://www.spigotmc.org/resources/playerkits-fully-configurable-kits-1-8-1-17.75185/
MIT License
8 stars 13 forks source link

Item is not correctly stored & preview item lores are lost #4

Closed jeffry1829 closed 2 years ago

jeffry1829 commented 2 years ago

Items with extra nbt tags given by other plugin will not be stored correctly(some nbt tags will disappear when claiming the kit)

When previewing items, item lores are gone.

I'm in minecraft version 1.17.1 with latest version plugin

Thank you!

jeffry1829 commented 2 years ago

In plugin version 2.17.1, nbt tags are stored correctly Only with the preview item lores problem

Ajneb97 commented 2 years ago

What do you mean item lores are gone? The item in the preview inventory is the same as the one you receive in the kit, so it should the exact item with the lore included.

jeffry1829 commented 2 years ago

What do you mean item lores are gone? The item in the preview inventory is the same as the one you receive in the kit, so it should the exact item with the lore included.

In editing the kit items, there's no lores

jeffry1829 commented 2 years ago

Also, I guess that you should use NBTBase.class in https://github.com/Ajneb97/PlayerKits/blob/main/src/pk/ajneb97/versiones/V1_17.java#L283 to avoid method not found exception.

Haven't see actual nms code though.

jeffry1829 commented 2 years ago

I used 2.17.1's v1_17.class to 2.21.2 Seems like it works

Ajneb97 commented 2 years ago

The nbt issue will be fixed in the next update, can you specify me the lore bug with pictures? Since I can't replicate the bug on my server.

Ajneb97 commented 2 years ago

Ok I found the issue, I will fix it in the next update