What is it supposed to do
The branch adds support for running this project in (three) docker containers via docker-compose by providing configuration files for docker.
How can we test your branch
The functionality can be tested by running the project in docker on your local machine. For this, docker needs to be installed (check the wiki on how to do that). When docker is installed, fill in the ormconfig.docker.json file (see wiki), go to the Seaqull folder in your terminal, and execute docker compose up --build. When it is done, go to http://localhost in your browser, you should see the application running, everything should work as it does when running the code.
1. General checklist
[x] a. Tested happy flow.
[ ] b. Tested unhappy flow. Not relevant
[x] c. No unexpected exceptions.
[ ] d. No code with high complexity. (Big O) Not relevant
[x] e. EOF newline.
[x] f. No floating comma's and spaces.
[x] g. No unexpected/unhandled errors.
[ ] h. Lines no longer than 'guideline' in IDE. Not relevant
[x] i. Correct indentation.
[x] j. No usage of legacy functionalities.
[ ] k. (JS) Curly braces on the sameline as reserved keywords (if () { instead of { on line below). Not relevant
[ ] l. (JS) No double quotes. Not applicable
[ ] m. (JS) Single newline above unique code structures and reserved keywords. Not relevant
[ ] n. (JS) Variables bundled where possible. Not relevant
[ ] o. (JS) No semi-colons except where they have a functional necessity, such as for-loops. Not relevant
[ ] p. (JS) No code that is meant exclusively for development, such as console.logs for data preview. Not relevant
2. If relevant, front-end checklistNot relevant
[ ] a. Responsive. (Desktop all the way to mobile 320px)
[ ] b. Using SCSS variables where relevant.
[ ] c. Relevant class names
[ ] d. No modified global SCSS properties, except if necessary and fully tested the impact.
[ ] e. Checked caniuse for more modern CSS properties.
3. If relevant, back-end checklist
[ ] a. No unhandled promise rejections. Not relevant
[ ] e. Used guards (middleware) where necessary and tested if route is guarded. Not relevant
4. If relevant, test these browsersNot relevant
[ ] a. Chrome
[ ] b. Firefox
[ ] c. Opera
[ ] d. Edge
[ ] e. Safari
PR Rules 1. Add relevant labels. 2. Select atleast two reviewers. 3. Assign all reviewers allowed to merge the branch, including yourself. 4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board. 5. Add to the corresponding milestone.
Reviewer info 1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.' 2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.
This form should be filled in by the author of this PR.
Closes #240
What is it supposed to do
The branch adds support for running this project in (three) docker containers via docker-compose by providing configuration files for docker.
How can we test your branch
The functionality can be tested by running the project in docker on your local machine. For this, docker needs to be installed (check the wiki on how to do that). When docker is installed, fill in the ormconfig.docker.json file (see wiki), go to the Seaqull folder in your terminal, and execute
docker compose up --build
. When it is done, go to http://localhost in your browser, you should see the application running, everything should work as it does when running the code.1. General checklist
if () {
instead of{
on line below). Not relevant2. If relevant, front-end checklist Not relevant
3. If relevant, back-end checklist
4. If relevant, test these browsers Not relevant
PR Rules
1. Add relevant labels.
2. Select atleast two reviewers.
3. Assign all reviewers allowed to merge the branch, including yourself.
4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board.
5. Add to the corresponding milestone.
Reviewer info
1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.'
2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.