AjobK / Seaqull

Seaqull programming blog
http://www.seaqull.com
3 stars 0 forks source link

269 followers to friends #314

Closed jerohero closed 3 years ago

jerohero commented 3 years ago

closes #269


What is it supposed to do
The follow/unfollow button changes to follow back/unfriend if that user follows the logged in user. A followsYou field was added to the return value of the GET profile route. image


How can we test your branch
Log in with two different accounts and let them follow each other to see if the text in the follow button changes properly.


Additional notes
n/a


1. General checklist


2. If relevant, front-end checklist


3. If relevant, back-end checklist


4. If relevant, test these browsers

AjobK commented 3 years ago

image

When a user follows me and I go to their profile it doesn't show me 'Follow Back' instead of 'Follow'

After refresh it seems to work though? Strange...

Reproduce

  1. Register a new user
  2. Follow another user
  3. Logout and login on another user without refreshing
  4. Go to followers by clicking on '1 followers' text and go to their profile
  5. It says 'Follow' instead of 'Follow back'
  6. Refresh, now it should say the correct thing
jerohero commented 3 years ago

Issue 2

image

Mobile buttons don't work well. Very unclear in which state of following you are with a person.

I didn't make this. Do you mean it doesn't represent the friend state with another user (follow back, unfriend) or the general state of following (follow, unfollow)?

jerohero commented 3 years ago

Issue 2

Mobile buttons don't work well. Very unclear in which state of following you are with a person.

image image

I replaced them with some icons from Font Awesome. I don't think these icons fit very well (considering the unfollow button when the user is not followed back is a check icon, but is an icon with a slash when the user does follow back), but I was unable to find anything better.