What is it supposed to do
Better loading of post instead of 'Not loaded' text. Added a loader icon when a post is loading. Also gives an error when post is not found instead of a permanent text indicating that something is loading.
How can we test your branch
Go to an invalid post URL like /post/blahblah. You should see a loader for a very short amount of time and then an error page indicating that the post does not exist.
Additional notes
None
1. General checklist
[x] a. Tested happy flow.
[x] b. Tested unhappy flow.
[x] c. No unexpected exceptions.
[x] d. No code with high complexity. (Big O)
[x] e. EOF newline.
[x] f. No linter warnings or errors.
2. If relevant, front-end checklist
[x] a. Responsive. (Desktop all the way to mobile 320px)
[x] b. Using SCSS variables where relevant.
[x] c. Relevant class names
[x] d. No modified global SCSS properties, except if necessary and fully tested the impact.
[x] e. Checked caniuse for more modern CSS properties.
[x] e. Used guards (middleware) where necessary and tested if route is guarded.
4. If relevant, test these browsers
[ ] a. Chrome
[ ] b. Firefox
[ ] c. Opera
[ ] d. Edge
[ ] e. Safari
PR Rules 1. Add relevant labels. 2. Select at least two reviewers. 3. Assign all reviewers allowed to merge the branch, including yourself. 4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board. 5. Add to the corresponding milestone.
Reviewer info 1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.' 2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.
This form should be filled in by the author of this PR.
closes #281
What is it supposed to do
Better loading of post instead of 'Not loaded' text. Added a loader icon when a post is loading. Also gives an error when post is not found instead of a permanent text indicating that something is loading.
How can we test your branch
Go to an invalid post URL like
/post/blahblah. You should see a loader for a very short amount of time and then an error page indicating that the post does not exist.Additional notes
None
1. General checklist
2. If relevant, front-end checklist
3. If relevant, back-end checklist
4. If relevant, test these browsers
PR Rules
1. Add relevant labels.
2. Select at least two reviewers.
3. Assign all reviewers allowed to merge the branch, including yourself.
4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board.
5. Add to the corresponding milestone.
Reviewer info
1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.'
2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.