AjobK / Seaqull

Seaqull programming blog
http://www.seaqull.com
3 stars 0 forks source link

340 login require direct #358

Closed jerohero closed 2 years ago

jerohero commented 2 years ago

closes #340


What is it supposed to do
When someone tries to use a functionality that requires the user to be logged in, a popup can be shown asking the user to log in. Doing so will redirect the user back to the page from whence those gents hath cometh. image


How can we test your branch
Currently the only functionality that directly requires users to sign in is liking posts (commenting does as well, but this just shows a button for signing in instead). Try liking posts while logged in and logged out. See if you get redirected properly.


1. General checklist


2. If relevant, front-end checklist


3. If relevant, back-end checklist


4. If relevant, test these browsers


jerohero commented 2 years ago

Add image

jerohero commented 2 years ago

Implemented unDraw images

AjobK commented 2 years ago

navigation.js is verwijderd @jerohero

Het liefst dit niet met een store doen, maar als het moet graag een store aanmaken weer en daar gebruik van maken.

Dit is echter ECHT NIET gewenst, gezien we van al deze stores af willen. Deze store was in een andere branch namelijk verwijderd. Hierdoor heb je merge conflicts.

AjobK commented 2 years ago

image

Stays after popup cancel

ryankroon00 commented 2 years ago

If you go to a post, like it, log out then try to dislike it, it doesn't show the popup.

jerohero commented 2 years ago

If you go to a post, like it, log out then try to dislike it, it doesn't show the popup.

This issue does not occur anymore after pulling from develop, since the logout button now redirects the user to the homepage. Should I still try to fix this issue, even though it doesn't occur anymore?