What is it supposed to do
The desktop, mobile and sub navigations has been revamped and refactored according to design. A few things differ from the design as noted in the issue, but this is intentional. Please refer to #347.
The scope of the issue was only the desktop navigation, but I did all of the navigations because it needed reworking badly and the inconsistencies were painful to look at.
Also, removed ui and nav store. It is bad practice to put UI related things in a global store like MobX. Only following stores are still available:
user store will be removed at another stage in the project (#337)
How can we test your branch
[ ] Check code
[ ] Click on desktop navigation buttons
[ ] Check desktop navigation responsiveness
[ ] Click on hamburger icon
[ ] Check if subnavigation items are correct
[ ] Resize to mobile with subnavigation open (responsiveness)
[ ] Check mobile navigation works correctly
[ ] Try to log out
[ ] Click on avatar
[ ] Spam hamburger?
[ ] Do random stuff...
[ ] Use your imagination
Additional notes
Things to keep in mind regarding the PR that don't fit in the previous two headings.
1. General checklist
[x] a. Tested happy flow.
[x] b. Tested unhappy flow.
[x] c. No unexpected exceptions.
[x] d. No code with high complexity. (Big O)
[x] e. EOF newline.
[x] f. No linter warnings or errors.
2. If relevant, front-end checklist
[x] a. Responsive. (Desktop all the way to mobile 320px)
[x] b. Using SCSS variables where relevant.
[x] c. Relevant class names
[x] d. No modified global SCSS properties, except if necessary and fully tested the impact.
[x] e. Checked caniuse for more modern CSS properties.
[ ] e. Used guards (middleware) where necessary and tested if route is guarded.
4. If relevant, test these browsers
[x] a. Chrome
[x] b. Firefox
[x] c. Opera
[x] d. Edge
[ ] e. Safari
PR Rules 1. Add relevant labels. 2. Select at least two reviewers. 3. Assign all reviewers allowed to merge the branch, including yourself. 4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board. 5. Add to the corresponding milestone.
Reviewer info 1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.' 2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.
This form should be filled in by the author of this PR.
closes #347
What is it supposed to do
The desktop, mobile and sub navigations has been revamped and refactored according to design. A few things differ from the design as noted in the issue, but this is intentional. Please refer to #347.
The scope of the issue was only the desktop navigation, but I did all of the navigations because it needed reworking badly and the inconsistencies were painful to look at.
Also, removed ui and nav store. It is bad practice to put UI related things in a global store like MobX. Only following stores are still available:
user store will be removed at another stage in the project (#337)
How can we test your branch
Additional notes
Things to keep in mind regarding the PR that don't fit in the previous two headings.
1. General checklist
2. If relevant, front-end checklist
3. If relevant, back-end checklist
4. If relevant, test these browsers
PR Rules
1. Add relevant labels.
2. Select at least two reviewers.
3. Assign all reviewers allowed to merge the branch, including yourself.
4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board.
5. Add to the corresponding milestone.
Reviewer info
1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.'
2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.