AjobK / Seaqull

Seaqull programming blog
http://www.seaqull.com
3 stars 0 forks source link

347 Refactor desktop, mobile and sub navigation #368

Closed AjobK closed 2 years ago

AjobK commented 2 years ago

closes #347


What is it supposed to do
The desktop, mobile and sub navigations has been revamped and refactored according to design. A few things differ from the design as noted in the issue, but this is intentional. Please refer to #347.

The scope of the issue was only the desktop navigation, but I did all of the navigations because it needed reworking badly and the inconsistencies were painful to look at.

Also, removed ui and nav store. It is bad practice to put UI related things in a global store like MobX. Only following stores are still available: image

user store will be removed at another stage in the project (#337)


How can we test your branch


Additional notes
Things to keep in mind regarding the PR that don't fit in the previous two headings.


1. General checklist


2. If relevant, front-end checklist


3. If relevant, back-end checklist


4. If relevant, test these browsers


PR Rules
1. Add relevant labels.
2. Select at least two reviewers.
3. Assign all reviewers allowed to merge the branch, including yourself.
4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board.
5. Add to the corresponding milestone.


Reviewer info
1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.'
2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.


This form should be filled in by the author of this PR.