Closed ShifuBadal closed 1 year ago
Changes proposed:
Changes above can be found in commits:
Could not find a way to fix seperator in tooltip, and the h1, h2, h3 fix with align is not optimal for SEO
Closing for now, needs more research. Is still in sprint @shivam-badal
Will re-open when it's ready
After merging the following PR looks like this, after the postContent revamp:
closes #350
What is it supposed to do
Whenever you are creating a post, or editing a post a tooltip needs to appear after selecting some text. With this tooltip you can apply some markdown to your written text. For mobile and tablet devices a mobile bar should appear which needs to be scrollable if there are a lot of buttons. It has the same behaviour as the tooltip, which is applying markdown to text.
The icon component got refactored. If you use a prefix, and an iconname which is found on: https://mui.com/components/material-icons/. If you have a custom svg you can use that too by using the prefix 'custom'. You then give the iconName the image file, which will eventually render it on your screen.
How can we test your branch
It should look like this:
And for mobile it should look like this:
If the icons are appearing the icon component using MUI works. Inspect code to further examine the component.
Additional notes
1. General checklist
2. If relevant, front-end checklist
3. If relevant, back-end checklist
4. If relevant, test these browsers
PR Rules
1. Add relevant labels.
2. Select at least two reviewers.
3. Assign all reviewers allowed to merge the branch, including yourself.
4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board.
5. Add to the corresponding milestone.
Reviewer info
1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.'
2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.