AjobK / Seaqull

Seaqull programming blog
http://www.seaqull.com
3 stars 0 forks source link

303 Shouldn't create post when not logged in #380

Closed ShifuBadal closed 2 years ago

ShifuBadal commented 2 years ago

closes #303


What is it supposed to do
This PR is supposed to fix the issue where a not logged in person can visit the /new-post route.


How can we test your branch

  1. Don't login

  2. Visit new-post route

  3. Login with your credentials

  4. Visit new-post route

You should be able to visit the new-post route only if you are logged in.


Additional notes
Things to keep in mind regarding the PR that don't fit in the previous two headings.


1. General checklist


2. If relevant, front-end checklist


3. If relevant, back-end checklist


4. If relevant, test these browsers


PR Rules
1. Add relevant labels.
2. Select at least two reviewers.
3. Assign all reviewers allowed to merge the branch, including yourself.
4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board.
5. Add to the corresponding milestone.


Reviewer info
1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.'
2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.


This form should be filled in by the author of this PR.

AjobK commented 2 years ago

https://blog.netcetera.com/how-to-create-guarded-routes-for-your-react-app-d2fe7c7b6122

image

ShifuBadal commented 2 years ago

Redirect to login

Fixed in commit: 143140a21fc671f4b2fec6e43d4bac5ea8bfd077