What is it supposed to do
This PR aims to add the functionality where adding icons by either FA or MUI is possible. Giving it a prefix={'mui'} with the corresponding iconName which can be found here, you can load a MUI icon.
Not giving it a prefix will automatically default to FA
How can we test your branch
I added a material icon to the comment section. Whenever you place a comment you can give it a like, reply or even delete it. I replaced the heart icon with a material one.
After that, you can scroll down and add a comment to the post.
You can see a heart icon appear, if you hover over it, it will become red too
Additional notes It should still be possible to use FA, so all the existing icons should still work.
1. General checklist
[x] a. Tested happy flow.
[x] b. Tested unhappy flow.
[x] c. No unexpected exceptions.
[x] d. No code with high complexity. (Big O)
[x] e. EOF newline.
[x] f. No linter warnings or errors.
2. If relevant, front-end checklist
[x] a. Responsive. (Desktop all the way to mobile 320px)
[x] b. Using SCSS variables where relevant.
[x] c. Relevant class names
[x] d. No modified global SCSS properties, except if necessary and fully tested the impact.
[x] e. Checked caniuse for more modern CSS properties.
4. If relevant, test these browsers
[x] a. Chrome
[x] b. Firefox
[ ] c. Opera
[ ] d. Edge
[ ] e. Safari
PR Rules 1. Add relevant labels. 2. Select at least two reviewers. 3. Assign all reviewers allowed to merge the branch, including yourself. 4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board. 5. Add to the corresponding milestone.
Reviewer info 1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.' 2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.
This form should be filled in by the author of this PR.
closes #369
What is it supposed to do
This PR aims to add the functionality where adding icons by either FA or MUI is possible. Giving it a
prefix={'mui'}with the corresponding iconName which can be found here, you can load a MUI icon.Not giving it a prefix will automatically default to FA
How can we test your branch
I added a material icon to the comment section. Whenever you place a comment you can give it a like, reply or even delete it. I replaced the heart icon with a material one.
Additional notes
It should still be possible to use FA, so all the existing icons should still work.
1. General checklist
2. If relevant, front-end checklist
4. If relevant, test these browsers
PR Rules
1. Add relevant labels.
2. Select at least two reviewers.
3. Assign all reviewers allowed to merge the branch, including yourself.
4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board.
5. Add to the corresponding milestone.
Reviewer info
1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.'
2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.