What is it supposed to do
It is supposed to make it possible to sign up via email and password. Beforehand signing in was done with username and password.
How can we test your branch
Try signing up with a brand new username and account
After successfully registering log out and try logging in with an email and password
Notice being logged in
Additional notes
Things to keep in mind regarding the PR that don't fit in the previous two headings.
1. General checklist
[x] a. Tested happy flow.
[x] b. Tested unhappy flow.
After registering twice with the same account, I got an error while registering. This issue appeared to be also on the develop branche, so this could be ignored.
[x] c. No unexpected exceptions.
[x] d. No code with high complexity. (Big O)
[x] e. EOF newline.
[x] f. No linter warnings or errors.
2. If relevant, front-end checklist
[x] a. Responsive. (Desktop all the way to mobile 320px)
[x] b. Using SCSS variables where relevant.
[x] c. Relevant class names
[x] d. No modified global SCSS properties, except if necessary and fully tested the impact.
[x] e. Checked caniuse for more modern CSS properties.
[x] e. Used guards (middleware) where necessary and tested if route is guarded.
4. If relevant, test these browsers
[x] a. Chrome
[x] b. Firefox
[ ] c. Opera
[ ] d. Edge
[ ] e. Safari
PR Rules 1. Add relevant labels. 2. Select at least two reviewers. 3. Assign all reviewers allowed to merge the branch, including yourself. 4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board. 5. Add to the corresponding milestone.
Reviewer info 1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.' 2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.
This form should be filled in by the author of this PR.
References #381
What is it supposed to do
It is supposed to make it possible to sign up via email and password. Beforehand signing in was done with username and password.
How can we test your branch
Additional notes
Things to keep in mind regarding the PR that don't fit in the previous two headings.
1. General checklist
2. If relevant, front-end checklist
3. If relevant, back-end checklist
4. If relevant, test these browsers
PR Rules
1. Add relevant labels.
2. Select at least two reviewers.
3. Assign all reviewers allowed to merge the branch, including yourself.
4. If relevant to the sprint, put related issue in 'Awaiting Approval' column on project board.
5. Add to the corresponding milestone.
Reviewer info
1. You can use aliases to refer to specific PR checklist items. For example 'Hey @JohnDoe, for this line please check 3.a and 1.d.'
2. Where possible, please use the suggestions feature in github so the author has a better idea of the solution you had in mind.