search

AjuntamentdeBarcelona / decidim-barcelona

Decidim Barcelona - Direct and participatory democracy web platform based on Decidim framework
https://www.decidim.barcelona
GNU Affero General Public License v3.0
78 stars 24 forks source link

Docker file is incomplete/inconsistent #183

Open jsperezg opened 6 years ago

jsperezg commented 6 years ago

:tophat: User Story

Docker file specifies that image should be built on top of ruby 2.4.0 but Gem file specifies that the minimum version is 2.4.2.

Another problem that I've found trying to run it from docker in my computer is that the gem decidim-dataviz is not being referenced during the image construction which causes the command bundle install to fail.

Docker file should change the first line to reference the right ruby version:

FROM ruby:2.4.2

Additionally it should import the databiz engine:

ADD ./decidim-dataviz/decidim-dataviz.gemspec /tmp/decidim-dataviz/decidim-dataviz.gemspec

jsperezg commented 6 years ago

command should be moved to docker-compose file as well.

josepjaume commented 6 years ago

Oh yeah, this Dockerfile isn't well maintained, as we're not developing on docker locally :(. We've since created a decidim official image for both development (and CI) and production. Maybe we could migrate to that one: https://hub.docker.com/r/decidim/decidim/

oalonson commented 5 years ago

Any action in this issue since Jan 2018? solved? could it be closed?