Internal evaluations

[entantoencuanto]

:tophat: What? Why?

This PR adds the view and the actions to manage internal evaluations in proposals.

:pushpin: Related Issues

• Fixes

  • 1

  • 2

  • 3

  • 4

  • 5

Testing

• In https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/4/manage/proposals/2

  • See the block of Internal evaluations
  • If assigned, create/edit an evaluation
  • See created evaluations

• In https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/4/manage/

  • See the new columns with Evaluation status

:camera: Screenshots

• Adds the table with the list of assigned valuators to a proposal, including buttons to unnassign valuators (only available for admins) and edit evaluation (only available to assigned valuators for their own evaluation). The table allows users to sort by last edition and status (#2)

• Implements a modal to create or edit evaluations. The modal allows valuators to select a status among the statuses defined for the component and edit the evaluation text (#2)

• Changes the valuation assignments column in proposals index to display the status of each proposal showing the evaluations count versus the total valuations assignments (#4)

• Allows exporting the internal evaluations (#5)

  

• Defines internal evaluations factory and adds some tests

:hearts: Thank you!

[furilo]

We have done all the issues in a single PR because they where very dependant.

[entantoencuanto]

Great job, @mllocs! I have reviewed the serialization part and it works perfectly

[NilHomedes]

Hi @entantoencuanto ! Here is my review, sorry it takes longer than expected.

New feature: Internal evaluation module

• [x] Design: Reduce “Actions” column width and increase “Evaluation” column width. The “Actions” column is taking too much width.

• [x] Design: Add borders to the table.

• [x] If I fill the internal evaluation modal in a language that is not the primary, it generates an error that is not very clear. To simplify and avoid this possible error, could we make this text field without language options?

• [x] I can delete a proposal status that has been used in an internal evaluation. If I do so, when I access to the admin of that proposal, then I get a 500 error. See: https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/4/manage/proposals/3. It should not be possible to delete a status that has been used in an internal evaluation.

Differentiate between the proposals I have already evaluated and those pending

• [x] As an admin, I can not filter by Evaluation. See the first AC of the issue. Given that I’m an administrator When I go to the proposals list Then I can filter by “Evaluation” > “Evaluated”, “Not evaluated”

Allow exporting internal evaluations

• [x] Export is not working. I’m not receiving the email.

Change evaluators column in admin proposals list Works fine!

[entantoencuanto]

Differentiate between the proposals I have already evaluated and those pending

• [ ] As an admin, I can not filter by Evaluation. See the first AC of the issue. Given that I’m an administrator When I go to the proposals list Then I can filter by “Evaluation” > “Evaluated”, “Not evaluated”

How can an administrator differentiate between evaluated and not evaluated proposals? As a valuator, the criteria are clear, among the assigned proposals the distinction is made between those that she has evaluated and those that she has not.

But as an admin with no valuator role and no assigned proposals when do we consider that a proposal is evaluated? When the proposal has at least one evaluation? When all assigned evaluations are completed?

I have added the filter to appear if a user is valuator (and the filter affects to their evaluations) or if the user o admin selects a valuator in the corresponding filter

[NilHomedes]

I have added the filter to appear if a user is valuator (and the filter affects to their evaluations) or if the user o admin selects a valuator in the corresponding filter

Oh, sorry @entantoencuanto I haven't noticed that. In that case, the need is covered. So an admin can select a valuator and, then, filter by "Evaluated", so the admin can easily see the proposals pending to evaluate that a valuator has.

[entantoencuanto]

Hi, @NilHomedes I have checked again the export and it seems to work with my user. ¿Which email has the user you are using to export the evaluations?

[NilHomedes]

Hi, @NilHomedes I have checked again the export and it seems to work with my user. ¿Which email has the user you are using to export the evaluations?

Hey @entantoencuanto, I'm not receiving it yet. I've tried with two different mails. In fact, I'm receiving the "Proposals CSV export file", but not the "Internal evaluations" file. See:

[entantoencuanto]

Some changes added:

• Change of body to be a text without translations
• Avoid exceptions showing evaluations when the state has been deleted. I think that this change fixes the errors exporting internal evaluations also, can you check again @NilHomedes?
• Prevent deletion of states when there are associated evaluations
• Delete evaluations associated to valuation assignments when the assignment is deleted
• Changes requested on the design of the table
• Tests additions

[NilHomedes]

Hey @rxnetwalker! This is ready to review by the AM Barcelona team, feel free to assign it.

[entantoencuanto]

Checksums checks added

[entantoencuanto]

You are right, done!