search

AkadenTK / superwarp

Addon for Windower 4 for FFXI that allows text commands to utilize homepoint, waypoint and survival guide teleport npcs
41 stars 31 forks source link

Suggestion: process command in a different order #36

Open Byrth opened 1 year ago

Byrth commented 1 year ago

Right now superwarp determines which map/ (warp type) the user is attempting to access, then validates the command. However, this means users need to remember the right token (ew, hp, sg, etc.) to access the map, and it pollutes the short command namespace. It's also unnecessary because there are very few (maybe no) situations where you're capable of passing validation for two maps at the same time just due to where you are spatially in the zone and the client's distance limits for actions.

Instead of the current processing, it should just iterate over maps until one finds the command valid, then use that. This would make superwarp a lot more extensible by allowing users to overload commands. So right now //sw ew enter or //ew enter enters an Escha Zone. It could instead be //sw enter, and that could also be implemented for mog gardens, various CS doors, etc. Now if someone is standing outside a door, they can just use //sw enter and see if it works.

I'm better at coming up with ideas than making time to implement them lately, but I may be able to make time to refactor it to work like this. Interested? Whaddayathink?

AkadenTK commented 1 year ago

I've considered it. I'll think some more on it, though. Main issue was the collision. And the check happens before it separates out to the different warp systems' handling. I need to reorder the checks etc anyway because right now it checks first if the warp NPC is near, then if it's a valid destination. That should be reversed too.

I've got a few projects brewing right now though so it may be a bit.