Akarin-project / Akarin

Akarin is a powerful server software from the 'new dimension'

https://akarin.app

Other

501 stars 63 forks source link

[1.12.2] JDK 9+ support? #220

Open ghost opened 2 years ago

ghost commented 2 years ago

When launching akarin-1.12.2-0.4.2 on jdk 9+ (in my case jdk11) the server will crash. latest.log Maybe we could update the mixin to solve the problem?

dani31c commented 2 years ago

Why using Java 8 in 1.12.2 tho?

dani31c commented 2 years ago

Most plugins for 1.12.2 wont work with it

ghost commented 2 years ago

Why using Java 8 in 1.12.2 tho?

Currently akarin uses launchwrapper and mixin 0.7 for code injection which don't support jdk 9+.

dani31c commented 2 years ago

Why using Java 8 in 1.12.2 tho?

Currently akarin uses launchwrapper and mixin 0.7 for code injection which don't support jdk 9+.

Well, mixin could be updated for 1.12.2, but there is really no point; Most of the plugins won't work past jre/jdk 8, and 1.12.2 itself was designed for jre/jdk 8, so doing that would still be quite unnecesary nowadays, you'll find no benefit on updating mixin for it

ghost commented 2 years ago

Why using Java 8 in 1.12.2 tho?

Currently akarin uses launchwrapper and mixin 0.7 for code injection which don't support jdk 9+.

Well, mixin could be updated for 1.12.2, but there is really no point; Most of the plugins won't work past jre/jdk 8, and 1.12.2 itself was designed for jre/jdk 8, so doing that would still be quite unnecesary nowadays, you'll find no benefit on updating mixin for it

Supporting jdk 9+ will be backward compatible and you can still run it with jdk 8 if your plugins don't support. Using higher version of jdk will give better gc, jit, and more cpu features. Actually vanilla and paper are both compiled in java 8 but can also run on jdk 9+ and many plugins are in fact designed for both 1.12- and 1.13+, common plugins designed specifically for 1.12 and java8 actually runs fine with latest java.

WesleyVanNeck commented 2 years ago

will try to get support for java 9 and up soonish

josephworks commented 1 year ago

@siyy123 @LegacyGamerHD What is the status on this?

WesleyVanNeck commented 1 year ago

@siyy123 @LegacyGamerHD What is the status on this?

not much am prety bussy with life

josephworks commented 1 year ago

Same! No worries!

ghost commented 1 year ago

@siyy123 @LegacyGamerHD What is the status on this?

busy too. jdk9+ support would be ok if the patch system can work but I do not have time to test :(