search

Akarin-project / Akarin

Akarin is a powerful server software from the 'new dimension'
https://akarin.app
Other
501 stars 63 forks source link

try to build with a newer mixin #229

Closed WesleyVanNeck closed 2 years ago

ghost commented 2 years ago

is this really works? I have tried using 0.8.4 and modified several asm opcodes but it cannot launch.

FatSaw commented 2 years ago

Just a reminder, that here you can encounter the same problem as with the log4j dependency. Some of the akarin dependencies use the old mixins (legacylauncher). Solutions: 1. Update legacylauncher. 2. Exclude the already compiled old version of the mixin and replace it with the new one. (same as the issue with log4j was solved, but it might not work here as the differences between the new and old version of the mixin can be significant).

ghost commented 2 years ago

I'd like to recommend replacing akarin's launchwrapper with modlauncher which would support higher version of mixin. Launchwrapper is pretty old now and is not maintained frequently but I'm not sure whether modlauncher would support 1.12.2. Modifying pom.xml is required but code modifications are needed too.