Akarin-project / Akarin

Akarin is a powerful server software from the 'new dimension'
https://akarin.app
Other
501 stars 63 forks source link

Upstream mixin experimental #240

Closed FatSaw closed 1 year ago

HowardZHY commented 1 year ago

Why did you include the mixin lib source in src/main?

josephworks commented 1 year ago

Yes, @FatSaw please let me know if you want me to fork a repo where we can apply our changes.

FatSaw commented 1 year ago

Why did you include the mixin lib source in src/main?

Because Mixin 8.+ did not want to work with Legacylauncher otherwise, or I am doing something wrong. I asked in the Sponge discord how to work with Legacylauncher at 8 Mixin. They answered me that Mixin himself should detect Legacylauncher, but this does not happen (Mixin first tries to find Modlauncher, does not find it and crashing). Mixin that I included in the source does not contain a start for Modlauncher and starts perfectly with Legacylauncher.

josephworks commented 1 year ago

Ok, so could we move your changes to Mixin to a new repository?

FatSaw commented 1 year ago

Ok, so could we move your changes to Mixin to a new repository?

Yes, it would be better than leaving the mixin sources here.

josephworks commented 1 year ago

@FatSaw Please move the org.spongepowered.mixin here: https://github.com/Akarin-project/Mixin and let me know when you are finished! I will deploy it to the CI and Repo.

FatSaw commented 1 year ago

@FatSaw Please move the org.spongepowered.mixin here: https://github.com/Akarin-project/Mixin and let me know when you are finished! I will deploy it to the CI and Repo.

I finished.

josephworks commented 1 year ago

image

josephworks commented 1 year ago

Please remove the mixin from akarin source and add that entry to the pom.xml

FatSaw commented 1 year ago

LegacyLauncher mixin dependency need to be upgraded to avoid conflicts. I close this pull reqest and make new pull reqest later after tests.