AkarinVS / L-SMASH-Works

Works based on L-SMASH project; This repo focuses on the common portion and the VapourSynth plugin. AviSynth users please use https://github.com/HomeOfAviSynthPlusEvolution/L-SMASH-Works. ffmpeg 5.0+ please use ffmpeg-4.5 branch.
47 stars 11 forks source link

LWLibavSource: repeat support is too much guesswork #2

Closed AkarinVS closed 3 years ago

AkarinVS commented 3 years ago

There is no guarantee that the repeat request is fully obeyed.

Instead, I'm proposing that if repeat=1 and the source video requested repeat, yet the source filter is somehow unable to process the repetition, the filter should fail explicitly and give the user the option to use repeat=0 to get a VFR clip. It should not silently return a VFR clip with the incorrect fps, which is much worse than failing.